Skip to content

Improve exports of spatial and temporal types #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

lutovich
Copy link
Contributor

Previously driver exported all spatial and temporal types and functions from both default and non-default export in v1 index.js file.

This PR makes it export all spatial and temporal types only from the types constant. Functions are still exported from both default and non-default exports to be consistent with existing isInt. Created two grouping constants spatial and temporal to export corresponding functions in a nicer, grouped way.

Previously driver exported all spatial and temporal types and functions
from both default and non-default export in v1 index.js file.

This commit makes it export all spatial and temporal types only from the
`types` constant. Functions are still exported from both default and
non-default exports to be consistent with existing `isInt`. Created
two grouping constants `spatial` and `temporal` to export corresponding
functions in a nicer, grouped way.
@lutovich lutovich requested a review from oskarhane April 16, 2018 16:30
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lutovich lutovich merged commit f8d3b8a into neo4j:1.6 Apr 17, 2018
@lutovich lutovich deleted the 1.6-improve-exports branch April 17, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants