Omit zero nanoseconds in toString() for temporal types
#361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes implementations of `toString()` function for `Duration`, `Time`, `LocalTime`, `LocalDateTime` and `DateTime`. Returned strings still remain valid ISO strings and represent same temporal values.
lutovich
force-pushed
the
1.6-ns-toString
branch
from
59cce23 to
43c4899
Compare
ali-ince
approved these changes
Apr 26, 2018
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes implementations of
toString()function forDuration,Time,LocalTime,LocalDateTimeandDateTime. Returned strings still remain valid ISO strings and represent same temporal values.