Replace ACK_FAILURE with RESET #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both have equivalent semantics with regards to failure handing. ACK_FAILURE will also be removed in the next Bolt protocol version.
Later better describes the logic of the function. There is no sync operation, only flushing of the queued messages/chunks. Responses arrive asynchronously are de-chunked and forwarded for the corresponding observers.
ali-ince
approved these changes
Aug 21, 2018
| } | ||
|
|
||
| const observer = { | ||
| _resetOnFailure() { |
There was a problem hiding this comment.
Wdyt about calling resetAndFlush instead, like resetAndFlush().finally(() => { /* clear failure */ })?
There was a problem hiding this comment.
It would definitely make the code a bit more concise but then failure will be cleared in a tick after the one that processes the RESET response. I think it might result in some queued callbacks to be failed unnecessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.