Fixes around initial discovery #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
approved these changes
Apr 30, 2019
| const connectionPromise = this._freshRoutingTable(accessMode).then(routingTable => { | ||
| if (accessMode === READ) { | ||
| const address = this._loadBalancingStrategy.selectReader(routingTable.readers); | ||
| const address = that._loadBalancingStrategy.selectReader(routingTable.readers); |
There was a problem hiding this comment.
Is variable that needed here? It looks like a reference copy to me.
There was a problem hiding this comment.
definitely not :) thanks for the catch.
ali-ince
force-pushed
the
1.7-sni-on-seed-router
branch
from
84239f9 to
0396124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a couple of fixes around initial/fallback routing discovery through seed router.
ServerAddressclass to hold server addresses, including resolved IP addresses, to be used across the driver to establish connections. This is specifically done to fix a failure where we forget host name (required forSNIto work) and rely on IP addresses to establish TLS connections where TLS connection is towards an endpoint that expectsSNI. The introduced class will always include the initial host name even after it is resolved through DNS.customresolver. This was not the intended behaviour with initial discovery and it is now defaulted to use seed URI applied to provided custom resolver results of which are passed on to DNS resolution. This is the behaviour which will apply on initial and fall-back to initial discovery.