Return promises and remove callback arguments #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies existing API's to return Promises instead of the previous callback mechanism.
Driver.close()
now returnsPromise<void>
.Transaction.commit()
andTransaction.rollback()
now returnsPromise<void>
rather than the internalResult
object which holds more and confusing information not applicable to the underlying commit/rollback operation (resolves Commit() return values do not have actions taken #260).Pool
implementation now stores it'sclosed
state and now is able to return errors if it's asked for a new connection (resolves Session and driver not closing; can still post queries @1.7.2 #442).Based on #445.