resolve #485 #486
Merged
resolve #485 #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck, the driver will try to divine meaning from Errors it didn't create, and the property might not be in a format it can understand.
|
I don't seem to have permission to access whatever went wrong with the build. If someone could tell me what's wrong, I'd be happy to fix it. I'd really like to see this bug fixed in the next 1.7.x release. |
|
Hi @ryanmeador, Thanks for your contribution. You should sign the CLA to get your changes to be tested by our CI and eventually get it merged. Please follow instructions mentioned here and then we'll be able to trigger the CI checks. Thanks. |
|
Hi @ali-ince. I submitted the CLA on August 31 at the same time I created the PR. If there's something wrong with it, please let me know. |
|
Hi @ali-ince. Is there something I can do to help move this PR forward? |
|
It's all good @ryanmeador. Thanks for your contribution! |
|
Thank you!
…On Mon, Sep 30, 2019 at 4:30 AM Ali Ince ***@***.***> wrote:
Merged #486 <#486>
into 1.7.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#486?email_source=notifications&email_token=AAI7IGFBEJ57IS7OIJMVZPDQMG2KJA5CNFSM4ISU3FZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT5EO5BQ#event-2672356998>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI7IGELZTNRQQM7ATDVHCLQMG2KJANCNFSM4ISU3FZQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the type of the error. Without this check, the driver will try to divine meaning from Errors it didn't create, and the property might not be in a format it can understand.