Pull Results in Batches #495

zhenlineo · 2019-10-17T14:20:06Z

Added fetchSize as an optional configuration option on driver config and session config.
Allowed async to pull results in batches.
Ensured Transaction#commit and Transaction#rollback to always finish query execution before commit/rollback.
Fixed a bug where parameter mode and database shall not be send on RUN message of session run.
Fixed some type errors in the type script

… and session config.

However session.close will send reset which cancels query execution.

…mary for a promise.

zhenlineo force-pushed the 4.0-pull-in-batches branch from 175ab6c to 78e13b9 Compare October 17, 2019 15:05

Adding fetchSize as an optional configuration option on driver config…

30b689a

… and session config.

zhenlineo force-pushed the 4.0-pull-in-batches branch from 78e13b9 to 30b689a Compare October 17, 2019 15:06

Zhen Li added 2 commits October 18, 2019 14:28

Allow async to make of PULL message to pull in batches

f4f6d6b

Commit and rollback shall cancel unfinished streaming

14f073d

However session.close will send reset which cancels query execution.

zhenlineo force-pushed the 4.0-pull-in-batches branch from 97db791 to 14f073d Compare October 18, 2019 15:23

zhenlineo changed the title ~~Adding fetchSize as an optional configuration option~~ Pull Results in Batches Oct 18, 2019

Should only call cancel to mark the state rather than calling the sum…

713a5c6

…mary for a promise.

zhenlineo force-pushed the 4.0-pull-in-batches branch from 2ad3878 to 5ccbcf9 Compare October 24, 2019 15:22

Fix cypher queries to drop contraints and indexes

c945ecc

zhenlineo force-pushed the 4.0-pull-in-batches branch from 5ccbcf9 to c945ecc Compare October 25, 2019 15:55

zhenlineo merged commit a17eee1 into neo4j:4.0 Oct 28, 2019

zhenlineo deleted the 4.0-pull-in-batches branch October 28, 2019 09:07

Provide feedback