Skip to content

Fix connection close by server treatment by WebSocket channels #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

bigmontz
Copy link
Contributor

The lack of set channel._open to false when the onclose event is triggered was causing the channel to be broken without the other parts of the driver noticed. In this way, the next iteration trying to get the broken connection will succeed in the trial, and run the query will result in an eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if needed.

The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
@bigmontz bigmontz force-pushed the 1.7-mark-ws-channel-as-close-onclose branch from 6a4a353 to 933c265 Compare March 1, 2021 15:42
@bigmontz bigmontz force-pushed the 1.7-mark-ws-channel-as-close-onclose branch from 266602b to 3512221 Compare March 1, 2021 16:46
@bigmontz bigmontz merged commit 0cc1145 into neo4j:1.7 Mar 1, 2021
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Mar 1, 2021
…#684)

The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 1, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Mar 1, 2021
…#684)

The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Mar 1, 2021
…#684)

The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Mar 1, 2021
…#684)

The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 1, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 1, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 1, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 3, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
bigmontz added a commit that referenced this pull request Mar 3, 2021
The lack of set channel._open to false when the onclose event is triggered was causing the channel be broken without the other parts of the driver notice. In tbis way, a next iteration trying to get the broken connection will succeded in the try and run the query will result in a eternal pending promise.

Mark the channel as closed enable the pool to discard and create a new connection if it needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant