Skip flaky test: test_should_write_successfully_on_leader_switch_using_tx_function #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_tx_function This test fails because of Javascript driver doesn't validate the tx before send it to the tx function. In this case, the transaction could be in a failed state when `tx.run` get called and it produces the `DriverError : : Cannot run query in this transaction, because it has been rolled back either because of an error or explicit termination. (N/A)`. This errant behaviour of the driver was fixed in the 5.0 with the TransactionPromise.
bigmontz
deleted the
4.4-flacky-test_should_write_successfully_on_leader_switch_using_tx_function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails because of Javascript driver doesn't validate the tx before send it to the tx function.
In this case, the transaction could be in a failed state when
tx.runget called and it produces theDriverError : : Cannot run query in this transaction, because it has been rolled back either because of an error or explicit termination. (N/A).This errant behaviour of the driver was fixed in the 5.0 with the TransactionPromise.