Slighly more robust tofu detection #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ const FEATURES = { | |||
| // that supports reading the whole certificate, eg this commit: | |||
| // https://github.com/nodejs/node/commit/345c40b6 | |||
| let desc = require('tls').TLSSocket.prototype.getPeerCertificate.toString(); | |||
| return desc.startsWith("function getPeerCertificate(detailed)"); | |||
| return desc.indexOf("function getPeerCertificate(detailed)") >= 0; | |||
There was a problem hiding this comment.
require('tls').TLSSocket.prototype.getPeerCertificate.length >= 1 is going to be more efficient and less prone to breakages.
pontusmelke
force-pushed
the
1.0-tofu-discover
branch
from
c78ab77 to
519a217
Compare
The checking of if platform supports trust-on-first-use is broken on node 6. We need a more robust way of detecting this, but until then this will have to do.
pontusmelke
force-pushed
the
1.0-tofu-discover
branch
from
519a217 to
fbeed19
Compare
| let desc = require('tls').TLSSocket.prototype.getPeerCertificate.toString(); | ||
| return desc.startsWith("function getPeerCertificate(detailed)"); | ||
| let desc = require('tls').TLSSocket.prototype.getPeerCertificate; | ||
| return desc.length() >= 1; |
There was a problem hiding this comment.
That's desc.length >= 1, it's a property not a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checking of if platform supports trust-on-first-use is broken on node 6.
We need a more robust way of detecting this, but until then this will have to do.