-
Notifications
You must be signed in to change notification settings - Fork 40
Implements neovim/neovim@9d77a07 APIs #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would just wait until it can be automated as discussed. |
what about |
it's Go idiom. basically, Go doesn't use underscore for variable, package name. |
Yes, I mean Please point out any obvious mistakes if there. such as "a Nvim" or etc. |
for note:
expect |
LGTM. which parts of this are auto-generated? Is the auto-generator process documented anywhere? One or two lines with a usage example in the README.md would be great. |
@justinmk No! always hand writing!! lol |
apiimp is supposed to be auto-generated using Line 3 in 8056758
see also: Line 1 in 82dd0a5
can you try that, and push the result here? |
Ah, but write API boilerplate to you said which meaning? |
So, the version of |
Ah, I see. you said means developer flow? If so, I'll create |
Just README.md is enough (1 or 2 lines, plus example). |
Yes, correct. |
I see, will do. |
@justinmk |
Implements neovim/neovim@9d77a07 APIs.
compare is here:
Note that
nvim_set_client_info
diff is only oftyp
arg,type
is Go reserve word.If you find a doc that is not appropriate, please give a line comment. (Note that I know different to the latest nvim doc/*.txt document comment.)
I will fix this PR, Or there are also inappropriate comments in other places, so I will fix it in the next PR.