feat!: Remove script preloading #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahetter
added
the
type: feature
ascorbic
reviewed
May 20, 2022
ericapisani
previously approved these changes
May 20, 2022
| import mergeWith from 'lodash.mergewith' | ||
|
|
||
| import { | ||
| HEADER_COMMENT, | ||
| IMMUTABLE_CACHING_HEADER, | ||
| COMMON_BUNDLES, |
There was a problem hiding this comment.
[pebble] This variable looks to be only used here, so you could remove it from the constants file as well
|
Nice! I've edited the PR title, because this is a breaking change so needs a major bump |
ascorbic
changed the title
ascorbic
approved these changes
May 23, 2022
Merged
|
Just in case something goes wrong, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #127 , Gatsby has removed script preloading as it was found that it was affecting performance on page load. This just does the same for our plugin.
Closes: #127