fix: run replacements function before HTML minification #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
kevinsamoei
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently merged a change to add
postMessagefunctionality, inserting it in a<script>, before the closing</body>tag (v3.4.0).What I didn't notice, is that we run HTML minification before replacements are made, and there was no
</body>left to match/replace (it is technically valid HTML to not have a closing</body>and</html>).This meant the additional
<script>is not currently being added. I had been testing against a standalone report which had not gone through the minifier. Previous replacements (now removed) had been working fine, as they were matching against strings which happened to not be changed during the process.This PR moves the
makeReplacementsfunction call to before the minification, with the bonus effect that the replaced code is now also minified.