feat: send reports on threshold failure #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
echoes-hq
bot
added
echoes/initiative: emea/web-vitals
and removed
echoes/initiative: emea/web-vitals
labels
jackbrewer
previously approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a score threshold is not met, we fail the build. However, we currently do not send the report data once a threshold fails. This PR aims to fix that by ensuring we always send the report whether the threshold failed or not
tested with this RC build image - https://github.com/netlify/buildbot/pull/2291
Dependent on: https://github.com/netlify/buildbot/pull/2291
fixes https://github.com/netlify/pillar-workflow/issues/731