fix(lighthouse): hide logs timestamp when running in tty #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaeesBhatti
approved these changes
Jul 13, 2020
erezrokah
added a commit
that referenced
this pull request
Jul 13, 2020
## [1.3.1](v1.3.0...v1.3.1) (2020-07-13) ### Bug Fixes * **lighthouse:** hide logs timestamp when running in tty ([#50](#50)) ([b2187ca](b2187ca))
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ehmicky
reviewed
Jul 13, 2020
| @@ -1,3 +1,6 @@ | |||
| // prevent logger from prefixing a date when running in tty | |||
| process.env.DEBUG_COLORS = 'true'; | |||
There was a problem hiding this comment.
Note that process.env.VAR = '...' sets the environment variable in the next plugins and/or build.command as well.
I am guessing this might not be intended. This could be fixed by restoring the previous value of this environment variable right after it's been used.
@erezrokah
There was a problem hiding this comment.
Good point, I'll change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See before:
https://app.netlify.com/sites/plugin-lighthouse/deploys/5f0c23c7c9f52900075bf9ca
And after:
https://app.netlify.com/sites/plugin-lighthouse/deploys/5f0c4a4177fc940007d8a269
Lighthouse uses
debugas a dependency which appends a timestamp when in tty:https://github.com/visionmedia/debug/blob/80ef62a3af4df95250d77d64edfc3d0e1667e7e8/src/node.js#L174
https://github.com/visionmedia/debug/blob/80ef62a3af4df95250d77d64edfc3d0e1667e7e8/src/node.js#L151
With older versions (like the one lighthouse uses) the only way to change it is via
colorsoption (with newer versions there is a simplerhideDateoption).We previously used
require('debug').inspectOpts.colors = trueto set the option, but that only works for the resolved version ofdebugand not all versions in the dependency tree.A better fix is to use an environment variable to set the option for all
debugversions. See https://github.com/visionmedia/debug/blob/80ef62a3af4df95250d77d64edfc3d0e1667e7e8/src/node.js#L120