fix(deps): Upgrade puppeteer using cache utils #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
requested review from
jackbrewer and
a team
and removed request for
a team
aitchiss
changed the title
aitchiss
commented
Jan 23, 2023
|
|
||
| export const onPreBuild = async ({ utils } = {}) => { | ||
| // Puppeteer relies on a global cache since v19.x, which otherwise would not be persisted in Netlify builds | ||
| await utils?.cache.restore(puppeteerCacheDir); |
There was a problem hiding this comment.
Nothing is logged out during this step by default - I'm not sure if we want to add a simple console log here/when we save the cache, just for info... what do you think?
There was a problem hiding this comment.
Yeah, I think it would be good to add something here and when saving. The Deploy Log now adds a section for onPreBuild, but without any content it may prompt questions.
There was a problem hiding this comment.
Yeah agreed, looks a bit weird empty like that. I've added a couple of lines:
jackbrewer
previously approved these changes
Jan 24, 2023
|
|
||
| export const onPreBuild = async ({ utils } = {}) => { | ||
| // Puppeteer relies on a global cache since v19.x, which otherwise would not be persisted in Netlify builds | ||
| await utils?.cache.restore(puppeteerCacheDir); |
There was a problem hiding this comment.
Yeah, I think it would be good to add something here and when saving. The Deploy Log now adds a section for onPreBuild, but without any content it may prompt questions.
jackbrewer
approved these changes
Jan 24, 2023
jackbrewer
added a commit
that referenced
this pull request
Jan 25, 2023
This reverts commit f831eb1.
jackbrewer
added a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/netlify/netlify-plugin-lighthouse/issues/510
Upgrades puppeteer, working around the new caching behaviour by making sure the puppeteer cache is saved/restored on each build.
Internal test steps: