Skip to content

fix(deps): Revert "chore(deps): update dependency netlify-plugin-cypress to ^2.2… #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

aitchiss
Copy link
Contributor

@aitchiss aitchiss commented Apr 18, 2023

….1 (#553)"

This reverts commit 88e9ec5.

We've received reports from some users that plugin runs are returning undefined in some cases. I managed to reproduce with the repo provided in the linked issue and with some additional logging saw that chromium wasn't being found - exactly similar to the issues we had when trying to upgrade puppeteer to latest.

The long and short of it is this cypress plugin upgrade also upgraded puppeteer to a version introducing those same issues again. I'm reverting the plugin bump until we resolve the puppeteer issue

To test:

  • Using the version of the plugin at this branch, deploy a build
  • When it completes, retry the same build (not clearing the cache)
  • Both builds and any subsequent one should show lighthouse reports

Follow ups

I'll create a follow up issue to add some more error logging to make this easier to spot in future (at the moment the error doesn't seem to bubble up to the UI output, and nothing is logged)

@aitchiss aitchiss requested a review from a team April 18, 2023 16:22
@netlify
Copy link

netlify bot commented Apr 18, 2023

👷 Deploy Preview for plugin-lighthouse processing.

Name Link
🔨 Latest commit cf0d299
🔍 Latest deploy log https://app.netlify.com/sites/plugin-lighthouse/deploys/643fd78249d3200008ab2ac8

package.json Outdated
@@ -52,7 +52,7 @@
"eslint-plugin-import": "^2.27.4",
"husky": "^8.0.1",
"jest": "^29.0.0",
"netlify-plugin-cypress": "^2.2.1",
"netlify-plugin-cypress": "^2.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"netlify-plugin-cypress": "^2.2.0",
"netlify-plugin-cypress": "2.2.0",

If we want to explicitly stay at 2.2.0 we'll need to remove the caret, as we'll still install the latest 2.x.x with it there.

@aitchiss
Copy link
Contributor Author

Closing this for now as it looks like there might be something more going on (I also notice we have the caret next to puppeteer, which needs properly locked down). The linked issue is in our triage to move it forward.

@aitchiss aitchiss closed this Apr 20, 2023
@aitchiss aitchiss deleted the sa/chore/revertCypress branch April 21, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants