fix(deps): Revert "chore(deps): update dependency netlify-plugin-cypress to ^2.2… #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
jackbrewer
reviewed
Apr 19, 2023
package.json
Outdated
| @@ -52,7 +52,7 @@ | |||
| "eslint-plugin-import": "^2.27.4", | |||
| "husky": "^8.0.1", | |||
| "jest": "^29.0.0", | |||
| "netlify-plugin-cypress": "^2.2.1", | |||
| "netlify-plugin-cypress": "^2.2.0", | |||
There was a problem hiding this comment.
Suggested change
| "netlify-plugin-cypress": "^2.2.0", | |
| "netlify-plugin-cypress": "2.2.0", |
If we want to explicitly stay at 2.2.0 we'll need to remove the caret, as we'll still install the latest 2.x.x with it there.
|
Closing this for now as it looks like there might be something more going on (I also notice we have the caret next to puppeteer, which needs properly locked down). The linked issue is in our triage to move it forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….1 (#553)"
This reverts commit 88e9ec5.
We've received reports from some users that plugin runs are returning
undefinedin some cases. I managed to reproduce with the repo provided in the linked issue and with some additional logging saw that chromium wasn't being found - exactly similar to the issues we had when trying to upgradepuppeteerto latest.The long and short of it is this cypress plugin upgrade also upgraded puppeteer to a version introducing those same issues again. I'm reverting the plugin bump until we resolve the puppeteer issue
To test:
Follow ups
I'll create a follow up issue to add some more error logging to make this easier to spot in future (at the moment the error doesn't seem to bubble up to the UI output, and nothing is logged)