-
Notifications
You must be signed in to change notification settings - Fork 33
[WRFL-2471] puppeteer upgrade #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy Preview for plugin-lighthouse processing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely strange - I'll see if I can figure out what's going on there |
ba1975d
to
9fc3998
Compare
I was still seeing duplicate lines as before, so I tried using the latest released version of the plugin to see if that made a difference but looks like I still see them. So it may just be a me problem or an existing issue |
Can you try clearing your cache and redeploying? Im wondering if it's still picking up the old version because the the actual version number of the plugin hasn't changed 🤔 |
I deployed a new project with the same repo and saw the same duplicates lines https://app.netlify.com/projects/boisterous-rugelach-8cf636/deploys/68433433e6ebb0175ed4ee51#L151-L155 |
Hmm OK thanks for the test site link, clearly something is still very funky |
This change is very similar to a previous one we had to revert in #544, but with some key differences:
Steps to test:
"@netlify/plugin-lighthouse": "https://github.com/netlify/netlify-plugin-lighthouse.git#sa/upgrade-puppeteer-with-cache-utils"