Feat/max error rate #171
Feat/max error rate #171
Conversation
This reverts commit 6059af1.
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
There was a problem hiding this comment.
I left a few minor comments for the less intrusive changes. Also, please be sure to run tox -e style and tox -e types locally and check those are passing -- there are a bunch of styling pieces, such as where parentheses are placed, how new lines are escaped, etc that are inconsistent with the ruff styling setup. Running tox -e style locally applied several fixes and raised some errors that couldn't be resolved without either modifying the code or ignoring them where appropriate.
For implementation, I think defaulting always to use the shutdown event is a good pattern rather than relying on two signals: either None being placed on the queue or the shutdown event being set if the maximum error rate is reached. I'd like to incorporate that into this to reduce complexity.
Also, I think a single parameter, max_errors, would be a great extension where it can be either max_error_rate or an absolute number of errors that can occur, allowing us to support all benchmarking pathways. Along these lines, for ones where we don't know how many requests are going to run, or maybe in general, using a simple sample of the last X requests based on the precision needed could work here to ensure rate can be set for those.
Additionally, with the above, as well as some combination logic in asyncio, we should be able to simplify the changes, so we don't need to make significant changes to the resolve requests pathways and can cancel for any type. For example, we should be able to replace the root process runner to call into async loops and handle the shutdown event globally in a central place with something like the following, where ideally shutdown_poll_interval would grab from the global settings so users can adjust it:
def run_process(
self,
type_: Literal["synchronous", "asynchronous"],
requests_queue: multiprocessing.Queue,
results_queue: multiprocessing.Queue,
shutdown_event: multiprocessing.Event,
shutdown_poll_interval: float,
process_id: int,
max_concurrency: int,
):
async def _process_runner():
if type_ == "synchronous":
loop_task = asyncio.create_task(self.synchronous_loop(...))
elif type_ == "asynchronous":
loop_task = asyncio.create_task(self.asyncronous_loop(...))
else:
raise ValueError(f"Invalid process type: {type_}")
shutdown_task = asyncio.create_task(
self.wait_for_shutdown(shutdown_event, shutdown_poll_interval)
)
done, pending = await asyncio.wait(
[
loop_task,
shutdown_task,
],
return_when=asyncio.FIRST_EXCEPTION,
)
for task in pending:
task.cancel()
try:
await task
except asyncio.CancelledError:
pass
for task in done:
if task.exception():
raise task.exception() # need to check and ignore cancelations
try:
asyncio.run(_process_runner())
except Exception as exc: # noqa: BLE001
logger.error(
f"Error in worker process {process_id}: {exc}",
exc_info=True,
stack_info=True,
)
finally:
shutdown_event.set() # ensure shutdown event is set to stop other processes
async def wait_for_shutdown(
self, shutdown_event: multiprocessing.Event, shutdown_poll_interval: float
):
while not shutdown_event.is_set():
await asyncio.sleep(shutdown_poll_interval)
raise asyncio.CancelledError("Shutdown event set, cancelling process loop.")
async def synchronous_loop(self, ...):
while True:
process_request = await self.get_request(requests_queue)
...
async def asyncronous_loop(self, ...):
while True:
process_request = await self.get_request(requests_queue)
...| @@ -625,12 +627,19 @@ def compile(self) -> GenerativeBenchmark: | |||
| request_start_time_targeted_delay_avg=self.requests_stats.request_start_time_targeted_delay.mean, | |||
| request_time_delay_avg=self.requests_stats.request_time_delay.mean, | |||
| request_time_avg=self.requests_stats.request_time.mean, | |||
| error_rate=error_rate, | |||
There was a problem hiding this comment.
It seems that implementing this as a calculated field under the StatusBreakdown would make sense, but that would require some work in that class to start generating computed values based on the types (numerics, collections, and generics). Putting this note here in case you're interested in generalizing the solution a bit more, but not a blocker from my side
| "The number of errored requests divided by the number " | ||
| "of errored requests. This can be higher than max_error_rate " | ||
| "(if applicable) cause it does not take into " | ||
| "account incomplete requests." |
There was a problem hiding this comment.
I'm not following this point, the error rate we calculate and compare to should never include incomplete, right?
src/guidellm/scheduler/scheduler.py
Outdated
| @@ -159,6 +166,17 @@ async def run( | |||
| run_info, | |||
| ) | |||
| if iter_result is not None: | |||
| if iter_result.request_info.errored \ | |||
There was a problem hiding this comment.
NIT: should use paranetheses rather than line escapes for if statements across multiple lines, tox -e style should fix
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
📦 Build Artifacts Available |
|
I've changed the logic as suggested to have a single termination method which is a After implementing the code like you suggested above I ran into an issue with Another super weird thing that happened is the raising specifically Also, I added the context of last X request as suggested but I feel that for the scenario where we do know the exact amount, i.e const rate + fixed duration, it is best to look at the entire run. |
Addressing this issue:
#105
--max-error-rateflag was added.It is only applicable in either or the the following scenarios:
max_requestsis setrate_typeisconstantandmax_durationis setsweepfor example)multiprocessing.Eventwhich is used to trigger a shutdown once we hitmax_error_rate.max_error_rate- added toreporterror_ratein the final report is calculated astotal errored / total requests finalizedi.e we excludeincomplete requests