Dark theme breaks highlighting

[PowerUser64]

Enabling the nextcloud dark theme makes the highlight color super low-contrast.

Steps to reproduce

1. Enable nextcloud dark theme
2. Make a note with some text
3. Highlight the text

Profit

Expected behaviour

I think the highlight color should match the accent color (in my case, green). I've seen glimpses of it, but whenever I go to normally highlight things, it's always this low-contrast white color that you see in the screenshot above.

Actual behaviour

The highlight color is the always this light color that doesn't contrast well with the text, which makes it hard to read.

Screenshots

Server

Please complete the following information.

• Notes app version: 4.9.2
• Nextcloud version: 28.0.3
• OS: NixOS (nextcloud is running in the official nextcloud apache docker container)
• Web server: apache
• PHP version: ???
• Database: mariadb

Nextcloud configuration:

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.mydomain.net"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.0.11",
        "overwrite.cli.url": "https:\/\/cloud.mydomain.net",
        "overwriteprotocol": "https",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "loglevel": 0,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpsecure": "ssl",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***"
    }
}

Client

Please complete the following information.

• Browser (incl. version): Mozilla Firefox 122.0
• OS: NixOS

Log files

(ask if you want them, doesn't seem like they're relevant here)

[joshtrichards]

I don't think this is a Notes matter. Server, perhaps.

The color is influenced by your background image/color too. Does the same highlighting matter happen when you open an .md file in the Files Web UI?

[PowerUser64]

Good question. In the standard markdown editor, the color is green, which matches the background image that I picked (the stock background image of a fern). I'm not sure why Notes always has a different color. I can sometimes see the normal highlighting color show up in Notes, but it's not frequent.

Standard Nextcloud md editor	Expected highlight color showing a little bit in the editor	Expected highlight color showing in preview mode

I think an additional step to my steps to reproduce then would be setting your background to that fern image.

[joshtrichards]

Oh, and you're also not using the newer Rich Text mode, but classic/MDE. Now we're getting somewhere. In that case, it likely is here in Notes.

[PowerUser64]

Oh, I didn't even know there was a new rich text mode! I actually really like the classic markdown editor because it does such a good job of showing what things will mostly look like without hiding the # **_markdown things_**, so I appreciate you continuing to support it! Same in the NC Notes android app.