fix: Wrap renaming of notes through autotile in locking context #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
bugfix/noid/lock
branch
from
0b20fc3 to
86b171a
Compare
|
Need to double check if setting a category also needs to be adapted, as I got a similar report for that one |
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/lock
branch
from
86b171a to
fdbf2b6
Compare
Moved the wrapping logic to a helper function and covered the category updates as well, which would run into the lock as they move the file around. |
blizzz
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise setting the title of the note will fail when editing through the text editor if files_lock is enabled