Feature/share single note #1146
Conversation
luka-nextcloud
force-pushed
the
feature/share-single-note
branch
from
67f74ce to
5441c0f
Compare
composer.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "require-dev": { | |||
| "nextcloud/ocp": "dev-stable25@dev", | |||
| "nextcloud/ocp": "dev-master", | |||
There was a problem hiding this comment.
Can you revert this specific change, currently we still cover multiple nextcloud versions and want to run the psalm checks against the ocp package towards the lowest supported.
There was a problem hiding this comment.
Class OCP\Share\Events\BeforeShareCreatedEvent does not exist on "nextcloud/ocp": "dev-stable25@dev", . We are listening to this event here
There was a problem hiding this comment.
Right, it is only available since 28.
Let me check if there is a fallback we can use for that then
There was a problem hiding this comment.
I pushed a fallback and added the event to the stub for the static analysis tests.
@luka-nextcloud I just noticed that my previously added commit was overwritten with yours and repushed that. Quick hint, if you use git push --force-with-lease instead of just a force push you will get notified about changes that have been made in the meantime. https://git-scm.com/docs/git-push#Documentation/git-push.txt---no-force-with-lease
There was a problem hiding this comment.
Ok, thanks for your tip.
luka-nextcloud
force-pushed
the
feature/share-single-note
branch
from
cc87da7 to
04ecd75
Compare
juliusknorr
force-pushed
the
feature/share-single-note
branch
2 times, most recently
from
3d3ab31 to
dd47097
Compare
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
feature/share-single-note
branch
from
dd47097 to
72cf34b
Compare
Resolves: #38