Skip to content

Chore(deps): Bump @nextcloud/vue from 7.3.0 to 7.8.2 #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 23, 2023

Bumps @nextcloud/vue from 7.3.0 to 7.8.2.

Release notes

Sourced from @​nextcloud/vue's releases.

v7.8.2

Full Changelog

🐛 Fixed bugs

  • Fix missing NcVNodes import in NcListItem #3907 (julien-nc)
  • Fix doubling attrs in NcPopover and improve docs #3876 (ShGKme)

Closed pull requests

v7.8.1

Full Changelog

🐛 Fixed bugs

Closed pull requests

v7.8.0

Full Changelog

Closed pull requests

v7.7.2

Full Changelog

🐛 Fixed bugs

... (truncated)

Changelog

Sourced from @​nextcloud/vue's changelog.

v7.8.2 (2023-03-22)

Full Changelog

🐛 Fixed bugs

  • Fix missing NcVNodes import in NcListItem #3907 (julien-nc)
  • Fix doubling attrs in NcPopover and improve docs #3876 (ShGKme)

Closed pull requests

v7.8.1 (2023-03-15)

Full Changelog

🐛 Fixed bugs

Closed pull requests

v7.8.0 (2023-03-02)

Full Changelog

Closed pull requests

v7.7.2 (2023-02-28)

Full Changelog

... (truncated)

Commits
  • fb40dc2 Merge pull request #3911 from nextcloud/v7.8.2
  • c38610f v7.8.2
  • 7cda57f Merge pull request #3876 from nextcloud/fix/popover-doubled-attrs
  • 9339ace Merge pull request #3904 from nextcloud/dependabot/npm_and_yarn/cypress-visua...
  • 1ed729f Merge pull request #3907 from nextcloud/fix/noid/import-ncvnodes-in-nclistitem
  • 2eaddde Merge pull request #3909 from nextcloud/dependabot/npm_and_yarn/glob-9.3.1
  • 1db165c Bump glob from 9.3.0 to 9.3.1
  • 8d13ee9 fix missing NcVNodes import in NcListItem
  • 0c707f2 Remove suffix from cypress base images
  • f51f50e Merge pull request #3903 from nextcloud/dependabot/npm_and_yarn/vue-styleguid...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Mar 23, 2023
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-7.8.2 branch from 3587c91 to 2687386 Compare March 23, 2023 09:51
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.3.0 to 7.8.2.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v7.3.0...v7.8.2)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/vue-7.8.2 branch from 2687386 to eb30074 Compare March 23, 2023 09:52
Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot bot merged commit fe9ea9a into master Mar 23, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nextcloud/vue-7.8.2 branch March 23, 2023 09:55
@theatischbein
Copy link
Contributor

theatischbein commented Mar 23, 2023

For me the building failed at commit fe9ea9a
I also tried to clone the repository again with the same result.

$> make dev-setup
...
$> make build-js 
npm run dev

> [email protected] dev
> webpack --node-env development --progress

Building notes 4.7.2 

asset notes-dashboard.js?v=485c7a76f8c936590995 2.12 KiB [emitted] [immutable] (name: dashboard) 1 related asset
asset notes-main.js?v=ae203d9d1c1f2aae1365 1.83 KiB [emitted] [immutable] (name: main) 1 related asset
./src/main.js 39 bytes [built] [code generated] [1 error]
./src/dashboard.js 39 bytes [not cacheable] [built] [code generated] [1 error]

ERROR in ./src/dashboard.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error: Cannot find module 'fs/promises'
Require stack:
- /tmp/notes/node_modules/babel-loader/lib/cache.js
- /tmp/notes/node_modules/babel-loader/lib/index.js
- /tmp/notes/node_modules/loader-runner/lib/loadLoader.js
- /tmp/notes/node_modules/loader-runner/lib/LoaderRunner.js
- /tmp/notes/node_modules/webpack/lib/NormalModuleFactory.js
- /tmp/notes/node_modules/webpack/lib/Compiler.js
- /tmp/notes/node_modules/webpack/lib/webpack.js
- /tmp/notes/node_modules/webpack/lib/index.js
- /tmp/notes/node_modules/webpack-cli/lib/webpack-cli.js
- /tmp/notes/node_modules/webpack-cli/lib/bootstrap.js
- /tmp/notes/node_modules/webpack-cli/bin/cli.js
- /tmp/notes/node_modules/webpack/bin/webpack.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/tmp/notes/node_modules/babel-loader/lib/cache.js:24:5)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)

ERROR in ./src/main.js
Module build failed: Error: Cannot find module 'fs/promises'
Require stack:
- /tmp/notes/node_modules/babel-loader/lib/cache.js
- /tmp/notes/node_modules/babel-loader/lib/index.js
- /tmp/notes/node_modules/webpack/lib/ProgressPlugin.js
- /tmp/notes/node_modules/webpack/lib/index.js
- /tmp/notes/node_modules/webpack-cli/lib/webpack-cli.js
- /tmp/notes/node_modules/webpack-cli/lib/bootstrap.js
- /tmp/notes/node_modules/webpack-cli/bin/cli.js
- /tmp/notes/node_modules/webpack/bin/webpack.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/tmp/notes/node_modules/babel-loader/lib/cache.js:24:5)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)

webpack 5.76.1 compiled with 2 errors in 269 ms
make: *** [Makefile:75: build-js] Error 1
``

@juliusknorr
Copy link
Member

Worked fine here, can you tell which node/npm version you are using?

@theatischbein
Copy link
Contributor

node -v
v12.22.9
npm -v
8.5.1

@theatischbein
Copy link
Contributor

theatischbein commented Mar 23, 2023

fixed it with node v19.8.1
thanks!

It seams node >= 14 is required. Maybe it can be automatically tested somewhere which node version is running?
https://medium.com/@su_bak/how-to-solve-cannot-find-module-fs-promises-848c66fed6c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants