Skip to content

Change HTML template parameters in line with similar parameters #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

Change HTML template parameters in line with similar parameters #222

merged 2 commits into from
Feb 14, 2022

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented Feb 14, 2022 •
edited
Loading

Proposed changes

Replace html_file_name and html_file_location with deployment_location inside nginx_config_html_demo_template.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Feb 14, 2022
@alessfg alessfg added the breaking change Implies a breaking change label Feb 14, 2022
@alessfg alessfg added this to the 0.5.0 milestone Feb 14, 2022
@alessfg alessfg changed the title Update HTML template parameters to bring in line with similar parameters Change HTML template parameters in line with similar parameters Feb 14, 2022
@alessfg alessfg merged commit 8094c64 into main Feb 14, 2022
@alessfg alessfg deleted the change-html-template-location branch February 14, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
breaking change Implies a breaking change
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg