Skip to content

fix: missing space in ubuntu docker template #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

rnitzan
Copy link
Contributor

@rnitzan rnitzan commented Apr 27, 2025

Proposed changes

Missing space in ubuntu docker template

Incorrect spacing for NAP DoS Ubuntu docker deployment template

No Space between "gpg]https" - causes build to fail

https://docs.nginx.com/nginx-app-protect-dos/deployment-guide/learn-about-deployment/#ubuntu-1804-bionic--2004-focal--2204-jammy--2404-noble-docker-deployment-example
Incorrect statement:

RUN printf "deb [signed-by=/usr/share/keyrings/nginx-archive-keyring.gpg]https://pkgs.nginx.com/plus/ubuntu lsb_release -cs nginx-plus\n" | tee /etc/apt/sources.list.d/nginx-plus.list
Location of Collected Data
https://docs.nginx.com/nginx-app-protect-dos/deployment-guide/learn-about-deployment/#ubuntu-1804-bionic--2004-focal--2204-jammy--2404-noble-docker-deployment-example

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@rnitzan rnitzan requested a review from a team as a code owner April 27, 2025 12:34
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nap-dos NGINX App Protect DOS labels Apr 27, 2025
@rnitzan rnitzan requested a review from ADubhlaoich April 27, 2025 12:36
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/458/

@rnitzan rnitzan merged commit f8651bc into main Apr 29, 2025
9 checks passed
@rnitzan rnitzan deleted the app-protect-dos-fix-docker-template-spacing branch April 29, 2025 14:25
weli02 pushed a commit to weli02/documentation that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nap-dos NGINX App Protect DOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants