-
Notifications
You must be signed in to change notification settings - Fork 83
NGF: Scaling control plane and data plane pods #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGF: Scaling control plane and data plane pods #490
Conversation
679132d
to
176e95a
Compare
176e95a
to
de1e55d
Compare
ebce7a6
to
b6768d3
Compare
b6768d3
to
3915a25
Compare
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
e336aee
to
2be20eb
Compare
2be20eb
to
4d1c847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content looks good to me after single change, i'll defer to @ADubhlaoich to any stylistic docs changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, sorry about the edit suggestions.
Co-authored-by: Alan Dooley <[email protected]>
38f389f
to
eb1ad77
Compare
Co-authored-by: Saylor Berman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM!
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need a how to guide on how to scale control plane and data plane
Solution: Introduces a new
how-to
guide on scaling control and data plane podsTesting: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
nginx/nginx-gateway-fabric#3235
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩