Skip to content

Add delay & retry to flakey weight splits test #7324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 7, 2025

Proposed changes

Add delay & retry to allow nginx to update

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 7, 2025 12:27
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Feb 7, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.10%. Comparing base (46fcf92) to head (8daa542).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7324   +/-   ##
=======================================
  Coverage   53.10%   53.10%           
=======================================
  Files          89       89           
  Lines       21074    21074           
=======================================
  Hits        11192    11192           
  Misses       9419     9419           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) February 12, 2025 09:25
@pdabelf5 pdabelf5 merged commit b453363 into main Feb 27, 2025
81 checks passed
@pdabelf5 pdabelf5 deleted the splits-test-wait branch February 27, 2025 12:09
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Feb 27, 2025
@pdabelf5 pdabelf5 changed the title add delay & retry to flakey weight splits test Add delay & retry to flakey weight splits test Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants