-
Notifications
You must be signed in to change notification settings - Fork 2k
Tiered Rate limit group maps #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7390 +/- ##
==========================================
+ Coverage 52.82% 53.08% +0.26%
==========================================
Files 89 89
Lines 20922 21074 +152
==========================================
+ Hits 11052 11188 +136
- Misses 9407 9421 +14
- Partials 463 465 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
Update docker images bc2e599d Co-authored-by: Paul Abel <[email protected]>
ec3c759
to
a0012db
Compare
vepatel
approved these changes
Feb 21, 2025
jjngx
approved these changes
Feb 21, 2025
AlexFenlon
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Generate
NGINX
maps to tie the JWT claim to the ratelimit zone key.This change adds two maps, one for each tiered rate (this map sets the rate limit zone key variable), aka the policy map, the other map aka the JWT claim map, sets the source variable of the policy map based on the content of the JWT claim.
It also follows the existing rate limit design, when the same policy is applied within the same
VirtualServer
, they share the rate limit zone.Given Policies:
Applied on VirtualServer:
A JWT of:
Will result in:
Checklist
Before creating a PR, run through this checklist and mark each as complete.