Skip to content

Add forward proxy support to Plus mgmt config #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 3, 2025
Merged

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • add controller.mgmt.usageReport.proxyHost and controller.mgmt.usageReport.proxyCredentialsSecretName to helm
  • add usage-report-proxy-host to the mgmt ConfigMap
  • add docs
  • add unit, helm tests and template tests
  • expand hostname regex to support up to 63 characters for TLD

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • [] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Mar 25, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7560/

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.15%. Comparing base (bca1685) to head (9443b17).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7560      +/-   ##
==========================================
+ Coverage   52.06%   52.15%   +0.09%     
==========================================
  Files          89       89              
  Lines       21312    21340      +28     
==========================================
+ Hits        11096    11130      +34     
+ Misses       9746     9741       -5     
+ Partials      470      469       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 1, 2025
@pdabelf5 pdabelf5 marked this pull request as ready for review April 3, 2025 09:52
@pdabelf5 pdabelf5 requested review from a team as code owners April 3, 2025 09:52
@AlexFenlon AlexFenlon merged commit 4bd97d6 into main Apr 3, 2025
32 checks passed
@AlexFenlon AlexFenlon deleted the forward-proxy branch April 3, 2025 15:00
@pdabelf5 pdabelf5 removed documentation Pull requests/issues for documentation chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels Apr 4, 2025
@pdabelf5 pdabelf5 changed the title Add forward proxy support to mgmt config Add forward proxy support to Plus mgmt config Apr 4, 2025
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants