NGF unnecessary reloads NGINX when it reconciles Secrets

[pleshakov]

Describe the bug

During longevity test, NGF for some reason periodically reconciled secrets

While the reason is unclear why NGF reconciled the Secret, the contents of the Secret (cert and key) wasn't changed. So in any case, NGF should not have regenerated the config and reloaded NGINX.

To Reproduce

Update the Secret without changing it. For example, add an annotation.
See that NFG would reload NGINX.

Expected behavior
no reload of NGINX

Your environment

NGF:

commit: "07d76315931501d878f3ed079142aa1899be1bd3"
date: "2023-09-28T16:49:51Z"
level: "info"
msg: "Starting NGINX Gateway Fabric in static mode"
ts: "2023-09-28T22:35:21Z"
version: "edge"

Kubernetes:

Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3-gke.100", GitCommit:"6466b51b762a5c49ae3fb6c2c7233ffe1c96e48c", GitTreeState:"clean", BuildDate:"2023-06-23T09:27:28Z", GoVersion:"go1.20.5 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}

Additional Context

This might be due to the controller-runtime forcing a reconciliation after a certain amount of time.

[bumarcell]

Yeah, what's up with the irrelevant secret reconciliation..? 🤔

[bumarcell]

Found the answer here