Skip to content

Refactor packages #709

Closed
Closed
@pleshakov

Description

@pleshakov

Discussed in #707

Originally posted by pleshakov June 1, 2023

After provisioner mode related code was merged 1df6bcd , we have 2 components in the internal package:

  • provisioner mode
  • static mode

Additionally, we have shared "framework" code that both provisioner and static mode use.

To reflect that, for better code organization, refactor the packages as below:

- internal
  - provisonermode
     - manager.go
     ... other files
  - staticmode
     - manager.go
     - nginx
     - state
     - status // status-related code, only relevant for static mode
  - framework // common framework code
    - events
    - controller
    - helpers
    - status // general purpose status-related code, both relevant for provisioner and static mode

As part of it, refactor the status package into two package, so that the one in framework/status doesn't depend on the graph.

Metadata

Metadata

Assignees

Labels

refinedRequirements are refined and the issue is ready to be implemented.tech-debtShort-term pain, long-term benefit

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions