Fix flaky unit tests #2364
Merged
Fix flaky unit tests #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A couple unit tests were flaky due to the ordering of maps or lists that were being parsed. Solution: Eliminate the randomness of the results.
sjberman
force-pushed
the
chore/fix-stream-unit-test
branch
from
5cea811 to
3b35c3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
- Coverage 88.85% 88.66% -0.20%
==========================================
Files 100 99 -1
Lines 7513 7284 -229
Branches 50 0 -50
==========================================
- Hits 6676 6458 -218
+ Misses 781 770 -11
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kate-osborn
approved these changes
Aug 12, 2024
lucacome
approved these changes
Aug 12, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: A couple unit tests were flaky due to the ordering of maps or lists that were being parsed. Solution: Eliminate the randomness of the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: A couple unit tests were flaky due to the ordering of maps or lists that were being parsed.
Solution: Eliminate the randomness of the results.