-
Notifications
You must be signed in to change notification settings - Fork 115
CP/DP split: Support nginx debug mode when provisioning Data Plane #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP split: Support nginx debug mode when provisioning Data Plane #3147
Conversation
I will link the documentation changes once I open a PR for it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3147 +/- ##
====================================================================
- Coverage 89.74% 79.51% -10.24%
====================================================================
Files 109 124 +15
Lines 11150 13475 +2325
Branches 50 62 +12
====================================================================
+ Hits 10007 10714 +707
- Misses 1083 2688 +1605
- Partials 60 73 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Corresponding docs pr here: nginx/documentation#215 |
4d5dd43
into
change/control-data-plane-split
…3147) Support nginx debug mode when provisioning the Data Plane. Problem: We want to have the option to provision nginx instances in debug mode. Solution: Add debug field to NginxProxy CRD. Also user can set debug field when installing through Helm by setting the nginx.debug flag.
…3147) Support nginx debug mode when provisioning the Data Plane. Problem: We want to have the option to provision nginx instances in debug mode. Solution: Add debug field to NginxProxy CRD. Also user can set debug field when installing through Helm by setting the nginx.debug flag.
…3147) Support nginx debug mode when provisioning the Data Plane. Problem: We want to have the option to provision nginx instances in debug mode. Solution: Add debug field to NginxProxy CRD. Also user can set debug field when installing through Helm by setting the nginx.debug flag.
…3147) Support nginx debug mode when provisioning the Data Plane. Problem: We want to have the option to provision nginx instances in debug mode. Solution: Add debug field to NginxProxy CRD. Also user can set debug field when installing through Helm by setting the nginx.debug flag.
Proposed changes
Support nginx debug mode when provisioning the Data Plane.
Problem: We want to have the option to provision nginx instances in debug mode.
Solution: Add
debug
field toNginxProxy
CRD. Also user can set debug field when installing through Helm by setting thenginx.debug
flag.Testing:
Manually tested that:
When an NginxProxy is attached to a GatewayClass (and there are no other NginxProxy resources on Gateways), if the debug field is changed, all gateway/nginx instances will be restarted and the new instances will use the nginx binary which matches the debug field.
When an NginxProxy is attached to a Gateway, if the debug field is changed, all corresponding nginx instances will be restarted and use the nginx binary which matches the debug fields. This overwrites any setting on the NginxProxy set on the GatewayClass. When the NginxProxy is removed/deleted from the Gateway, the NginxProxy settings on the GatewayClass take over and if they were different, nginx instances are restarted with the settings from the NginxProxy on the GatewayClass.
Initial NginxProxy on installation through Helm correctly has the debug field set if it was specified on installation.
Closes #3115
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.