Skip to content

Add support for additional service labels to the helm chart #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

cyril-s
Copy link

@cyril-s cyril-s commented Apr 9, 2025

Proposed changes

Problem: It's not possible to add extra lables to the nginx gateway service (to select a particular CiliumLoadBalancerIPPool, for example).

Solution: Add support for adding extra labels to the nginx gateway service.

Testing: The following command renders a service manifest with an extra label lb-ip-pool=private as expected.

helm template ngf charts/nginx-gateway-fabric/ --set service.labels.lb-ip-pool=private -s templates/service.yaml

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: It's not possible to add extra lables to the nginx gateway
service (to select a particular CiliumLoadBalancerIPPool, for example)

Solution: Add support for adding extra labels to the nginx gateway service

Testing: `helm template ngf charts/nginx-gateway-fabric/ --set service.labels.lb-ip-pool=private -s templates/service.yaml`
rendered a service manifest with an extra label `lb-ip-pool=private` as expected
Copy link

nginx-bot bot commented Apr 9, 2025

Hi @cyril-s! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
See Linking a pull request to an issue and our Pull Request Guidelines for more information.

@nginx-bot nginx-bot bot added the community label Apr 9, 2025
Copy link
Contributor

github-actions bot commented Apr 9, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Apr 9, 2025
@cyril-s
Copy link
Author

cyril-s commented Apr 9, 2025

I have hereby read the F5 CLA and agree to its terms

@sjberman
Copy link
Collaborator

Hi @cyril-s, thanks for the submission. We're going to hold off on this change right now because our architecture is changing in our next release (2.0) and there will be a different way to specify labels on the Service.

The control plane will provision an nginx data plane (including a Service) when you create your Gateway object (instead of the current architecture of a shared Pod between the control/data planes). On the Gateway object, you'll be able to set the infrastructure.labels field to propagate any labels to the nginx Service/Deployment objects that are provisioned. We'll have documentation around this as well.

@sjberman sjberman closed this Apr 16, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants