Skip to content

CP/DP Split: Remove prometheus logger #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Apr 30, 2025

The prometheus logger is no longer needed since we don't collect nginx metrics in the control plane anymore.

Also updated agent dependencies to fix the broken build.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


The prometheus logger is no longer needed since we don't collect nginx metrics in the control plane anymore.

Also updated agent dependencies to fix the broken build.
@sjberman sjberman requested a review from a team as a code owner April 30, 2025 16:21
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Apr 30, 2025
@sjberman sjberman closed this Apr 30, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 30, 2025
@sjberman sjberman reopened this Apr 30, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in NGINX Gateway Fabric Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (6337c97) to head (8840c13).
Report is 265 commits behind head on change/control-data-plane-split.

Files with missing lines Patch % Lines
internal/mode/static/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #3349      +/-   ##
===================================================================
- Coverage                            89.74%   86.70%   -3.05%     
===================================================================
  Files                                  109      129      +20     
  Lines                                11150    14728    +3578     
  Branches                                50       62      +12     
===================================================================
+ Hits                                 10007    12770    +2763     
- Misses                                1083     1814     +731     
- Partials                                60      144      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjberman sjberman merged commit f9cad70 into change/control-data-plane-split Apr 30, 2025
36 of 37 checks passed
@sjberman sjberman deleted the chore/remove-promlog branch April 30, 2025 18:00
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants