-
Notifications
You must be signed in to change notification settings - Fork 114
CP/DP Split: Remove prometheus logger #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Split: Remove prometheus logger #3349
Conversation
The prometheus logger is no longer needed since we don't collect nginx metrics in the control plane anymore. Also updated agent dependencies to fix the broken build.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3349 +/- ##
===================================================================
- Coverage 89.74% 86.70% -3.05%
===================================================================
Files 109 129 +20
Lines 11150 14728 +3578
Branches 50 62 +12
===================================================================
+ Hits 10007 12770 +2763
- Misses 1083 1814 +731
- Partials 60 144 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
f9cad70
into
change/control-data-plane-split
The prometheus logger is no longer needed since we don't collect nginx metrics in the control plane anymore.
Also updated agent dependencies to fix the broken build.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.