Skip to content

Remove init container from architecture doc #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: The architecture doc still mentions the init container even though it was removed in #934

Solution: Remove the init container from the architecture doc.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner August 17, 2023 15:31
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 17, 2023
@kate-osborn kate-osborn force-pushed the docs/remove-mention-init branch from b732f8a to 4305edd Compare August 17, 2023 18:56
@kate-osborn kate-osborn merged commit 86de560 into nginx:main Aug 17, 2023
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: The architecture doc still mentions the init container even though it was removed in nginx#934

Solution: Remove the init container from the architecture doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants