Skip to content

Add check for external contributor #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Aug 12, 2024

Proposed changes

Community PR preview builds will always fail because forks cannot get access to github secrets.
NIC have implemented this on their repository with this PR nginx/kubernetes-ingress#6123, but ideally this would be managed directly in docs-actions, to avoid code duplication across OSS repos.

Expected Behavior

Creating a PR from a fork will not run the docs-actions, they will be skipped
Creating a PR directly on the repo will continue to operate as it does currently

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@nginx-jack nginx-jack requested a review from a team as a code owner August 12, 2024 09:37
@nginx-jack nginx-jack force-pushed the external-workflow-check branch from 46f0c01 to 8a13911 Compare August 12, 2024 09:43
@nginx-jack nginx-jack requested a review from a team as a code owner August 12, 2024 09:43
mjang
mjang previously approved these changes Aug 12, 2024
Copy link

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for clarification... I'm not a dev, but it's based on my reading of L67 of the docs-build-push.yml file.

lamATnginx
lamATnginx previously approved these changes Aug 14, 2024
Copy link
Contributor

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nginx-jack nginx-jack force-pushed the external-workflow-check branch from 228dbf8 to 4148390 Compare August 16, 2024 09:47
@nginx-jack nginx-jack requested a review from lamATnginx August 16, 2024 09:48
@nginx-jack nginx-jack merged commit 367b5a1 into main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants