Skip to content

Renames the control plane label #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Renames the control plane label #188

merged 1 commit into from
Feb 14, 2025

Conversation

ciroque
Copy link
Collaborator

@ciroque ciroque commented Feb 14, 2025

This accommodates the change made in v1.20 which became the standard in 1.24.

This will require users to have Kubernetes v1.24 or higher; while NLK will run on lower versions, the control plane Nodes will not be excluded.

Closes #187

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

…lane

This accommodates the change made in v1.20 which became the standard in 1.24.

This will require users to have Kubernetes v1.24 or higher; while NLK will run on lower versions, the control plane Nodes will not be excluded.
@ciroque ciroque requested a review from chrisakker as a code owner February 14, 2025 18:28
@ciroque ciroque merged commit cbc295e into main Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the Master Node label to node-role.kubernetes.io/control-plane
1 participant