Skip to content

pep8 violations #597

Closed
Closed
@mwaskom

Description

@mwaskom

Nipype is not the most pep8-abiding package out there. Maybe this is unavoidable, but I do think in general code that follows these guidelines is something to strive for. Below is a current (7/1/2013) list of the .py files and the number of pep complaints, obtained with

for f in `find . -name "*.py"`; do count=`pep8 $f | wc -l`; echo -n "    $count    "; echo $f; done | sort -r

Reducing these counts will yield a cleaner, better codebase, so if you find yourself with 20 minutes to kill, maybe take a crack at one of the bigger numbers?

     515    ./nipype/interfaces/fsl/tests/test_model.py
     497    ./nipype/interfaces/freesurfer/tests/test_model.py
     459    ./nipype/workflows/dmri/connectivity/group_connectivity.py
     440    ./nipype/interfaces/freesurfer/tests/test_preprocess.py
     414    ./nipype/workflows/dmri/mrtrix/connectivity_mapping.py
     391    ./examples/dmri_connectivity_advanced.py
     355    ./nipype/workflows/smri/ants/antsRegistrationBuildTemplate.py
     354    ./nipype/interfaces/cmtk/cmtk.py
     336    ./nipype/interfaces/camino/dti.py
     335    ./nipype/workflows/dmri/camino/connectivity_mapping.py
     326    ./examples/dmri_connectivity.py
     304    ./nipype/workflows/fmri/fsl/preprocess.py
     301    ./nipype/interfaces/fsl/tests/test_dti.py
     278    ./nipype/interfaces/fsl/tests/test_preprocess.py
     276    ./nipype/interfaces/camino/convert.py
     259    ./nipype/interfaces/spm/tests/test_preprocess.py
     237    ./examples/fmri_spm_face.py
     231    ./nipype/algorithms/modelgen.py
     228    ./nipype/interfaces/fsl/preprocess.py
     222    ./nipype/workflows/smri/ants/ANTSBuildTemplate.py
     222    ./nipype/interfaces/fsl/dti.py
     215    ./nipype/interfaces/freesurfer/model.py
     209    ./nipype/interfaces/freesurfer/preprocess.py
     202    ./nipype/interfaces/mrtrix/preprocess.py
     192    ./examples/fmri_fsl_feeds.py
     181    ./examples/fmri_fsl.py
     180    ./examples/fmri_spm_dartel.py
     179    ./nipype/pipeline/tests/test_engine.py
     179    ./nipype/interfaces/spm/preprocess.py
     176    ./nipype/interfaces/meshfix.py
     174    ./examples/fmri_spm.py
     167    ./nipype/interfaces/spm/tests/test_model.py
     167    ./examples/dmri_mrtrix_dti.py
     166    ./nipype/interfaces/freesurfer/utils.py
     163    ./nipype/interfaces/fsl/tests/test_maths.py
     154    ./examples/fmri_spm_nested.py
     152    ./examples/fmri_freesurfer_smooth.py
     151    ./nipype/interfaces/slicer/legacy/registration.py
     146    ./nipype/interfaces/base.py
     143    ./nipype/interfaces/cmtk/nx.py
     142    ./nipype/workflows/dmri/fsl/tbss.py
     135    ./nipype/interfaces/spm/model.py
     135    ./nipype/interfaces/slicer/registration/specialized.py
     132    ./nipype/interfaces/slicer/diffusion/diffusion.py
     130    ./nipype/workflows/dmri/fsl/dti.py
     127    ./nipype/interfaces/mrtrix/convert.py
     123    ./nipype/interfaces/fsl/utils.py
     121    ./nipype/interfaces/traits_extension.py
     120    ./nipype/algorithms/tests/test_moments.py
     116    ./examples/fmri_spm_auditory.py
     115    ./nipype/workflows/smri/freesurfer/utils.py
     109    ./nipype/workflows/dmri/camino/diffusion.py
     109    ./nipype/interfaces/mrtrix/tensors.py
     107    ./nipype/workflows/dmri/mrtrix/diffusion.py
     105    ./nipype/interfaces/ants/registration.py
     105    ./examples/dmri_camino_dti.py
     102    ./examples/smri_antsregistration_build_template.py
     101    ./nipype/interfaces/diffusion_toolkit/dti.py
     100    ./nipype/interfaces/tests/test_base.py
     100    ./examples/dmri_fsl_dti.py
      99    ./nipype/interfaces/spm/utils.py
      97    ./nipype/interfaces/mrtrix/tracking.py
      91    ./nipype/interfaces/diffusion_toolkit/odf.py
      91    ./nipype/interfaces/dcmstack.py
      90    ./examples/rsfmri_fsl.py
      89    ./nipype/interfaces/spm/tests/test_utils.py
      89    ./nipype/interfaces/slicer/registration/brainsfit.py
      87    ./nipype/interfaces/dipy/tracks.py
      80    ./examples/fmri_nipy_glm.py
      78    ./nipype/workflows/dmri/connectivity/nx.py
      78    ./nipype/interfaces/fsl/model.py
      77    ./nipype/interfaces/nipy/model.py
      76    ./nipype/interfaces/slicer/segmentation/specialized.py
      69    ./nipype/workflows/fmri/spm/preprocess.py
      66    ./nipype/utils/filemanip.py
      66    ./nipype/interfaces/slicer/surface.py
      61    ./examples/smri_ants_build_template.py
      61    ./examples/fmri_fsl_reuse.py
      59    ./nipype/workflows/dmri/mrtrix/group_connectivity.py
      55    ./nipype/interfaces/cmtk/convert.py
      55    ./examples/dmri_dtk_odf.py
      54    ./nipype/algorithms/rapidart.py
      53    ./nipype/pipeline/tests/test_utils.py
      52    ./doc/sphinxext/numpy_ext/docscrape.py
      51    ./nipype/interfaces/freesurfer/tests/test_utils.py
      51    ./examples/dmri_dtk_dti.py
      50    ./nipype/interfaces/afni/preprocess.py
      49    ./nipype/interfaces/cmtk/parcellation.py
      48    ./examples/frontiers_paper/smoothing_comparison.py
      46    ./nipype/workflows/dmri/camino/group_connectivity.py
      46    ./nipype/algorithms/misc.py
      45    ./nipype/workflows/dmri/fsl/tests/test_tbss.py
      44    ./nipype/interfaces/slicer/filtering/arithmetic.py
      42    ./examples/smri_ants_registration.py
      41    ./nipype/interfaces/dynamic_slicer.py
      39    ./nipype/interfaces/fsl/maths.py
      39    ./nipype/interfaces/ants/segmentation.py
      39    ./nipype/interfaces/afni/tests/test_preprocess.py
      38    ./nipype/interfaces/ants/legacy.py
      38    ./examples/workshop_dartmouth_2010.py
      37    ./nipype/interfaces/slicer/filtering/denoising.py
      36    ./nipype/interfaces/slicer/generate_classes.py
      36    ./nipype/interfaces/camino2trackvis/convert.py
      36    ./nipype/interfaces/ants/resampling.py
      36    ./examples/frontiers_paper/workflow_from_scratch.py
      36    ./examples/dmri_group_connectivity_mrtrix.py
      35    ./tools/interface_inputspec_testwriter.py
      34    ./nipype/interfaces/io.py
      33    ./nipype/utils/misc.py
      33    ./nipype/interfaces/matlab.py
      32    ./nipype/interfaces/slicer/filtering/resamplescalarvectordwivolume.py
      32    ./nipype/external/cloghandler.py
      31    ./nipype/pipeline/plugins/tests/test_multiproc_nondaemon.py
      31    ./nipype/fixes/numpy/testing/noseclasses.py
      30    ./nipype/utils/docparse.py
      30    ./nipype/interfaces/utility.py
      30    ./nipype/interfaces/fsl/tests/test_base.py
      30    ./examples/dmri_group_connectivity_camino.py
      29    ./nipype/interfaces/nitime/tests/test_nitime.py
      28    ./nipype/utils/tests/test_filemanip.py
      28    ./examples/tessellation_tutorial.py
      27    ./nipype/workflows/rsfmri/fsl/resting.py
      27    ./doc/sphinxext/inheritance_diagram.py
      24    ./nipype/interfaces/nitime/analysis.py
      24    ./nipype/interfaces/camino/connectivity.py
      23    ./nipype/interfaces/slicer/registration/brainsresample.py
      23    ./nipype/interfaces/slicer/quantification/changequantification.py
      23    ./nipype/interfaces/slicer/filtering/n4itkbiasfieldcorrection.py
      23    ./nipype/interfaces/slicer/filtering/morphology.py
      23    ./nipype/interfaces/cmtk/nbs.py
      23    ./nipype/info.py
      22    ./nipype/interfaces/slicer/legacy/filtering.py
      22    ./nipype/interfaces/slicer/converters.py
      22    ./nipype/algorithms/tests/test_modelgen.py
      22    ./examples/fmri_openfmri.py
      21    ./doc/sphinxext/autosummary_generate.py
      21    ./build_docs.py
      20    ./tools/run_interface.py
      20    ./nipype/pipeline/utils.py
      18    ./tools/interfacedocgen.py
      18    ./nipype/interfaces/mne/base.py
      18    ./nipype/interfaces/fsl/tests/test_utils.py
      18    ./nipype/interfaces/dcm2nii.py
      18    ./examples/fmri_slicer_coregistration.py
      17    ./nipype/workflows/dmri/fsl/tests/test_dti.py
      17    ./nipype/interfaces/slicer/quantification/petstandarduptakevaluecomputation.py
      17    ./nipype/interfaces/slicer/legacy/diffusion/denoising.py
      17    ./nipype/fixes/numpy/testing/nosetester.py
      17    ./doc/sphinxext/numpy_ext/docscrape_sphinx.py
      17    ./doc/conf.py
      16    ./nipype/interfaces/slicer/segmentation/simpleregiongrowingsegmentation.py
      16    ./nipype/interfaces/slicer/filtering/histogrammatching.py
      15    ./nipype/interfaces/slicer/filtering/extractskeleton.py
      15    ./doc/sphinxext/numpy_ext/numpydoc.py
      14    ./nipype/workflows/fmri/fsl/estimate.py
      14    ./nipype/pipeline/plugins/dagman.py
      14    ./nipype/pipeline/plugins/base.py
      14    ./nipype/interfaces/slicer/utilities.py
      14    ./nipype/caching/memory.py
      13    ./setup.py
      13    ./nipype/workflows/misc/utils.py
      13    ./nipype/utils/onetime.py
      13    ./nipype/interfaces/slicer/legacy/segmentation.py
      13    ./nipype/interfaces/slicer/filtering/votingbinaryholefillingimagefilter.py
      13    ./nipype/interfaces/ants/utils.py
      13    ./nipype/interfaces/ants/base.py
      13    ./examples/rsfmri_fsl_compcorr.py
      12    ./nipype/interfaces/slicer/filtering/thresholdscalarvolume.py
      12    ./nipype/interfaces/nipy/utils.py
      12    ./nipype/algorithms/icc.py
      11    ./tools/run_examples.py
      11    ./nipype/pipeline/plugins/tests/test_somaflow.py
      11    ./nipype/pipeline/plugins/tests/test_pbs.py
      11    ./nipype/pipeline/plugins/tests/test_multiproc.py
      11    ./nipype/pipeline/plugins/tests/test_linear.py
      11    ./nipype/pipeline/plugins/ipythonx.py
      11    ./nipype/interfaces/slicer/filtering/checkerboardfilter.py
      11    ./nipype/interfaces/diffusion_toolkit/postproc.py
      11    ./nipype/interfaces/c3.py
      11    ./nipype/external/portalocker.py
      10    ./nipype/testing/decorators.py
      10    ./nipype/pipeline/plugins/tests/test_debug.py
      10    ./nipype/interfaces/slicer/filtering/imagelabelcombine.py
       9    ./nipype/utils/logger.py
       9    ./nipype/pipeline/plugins/ipython.py
       8    ./nipype/workflows/smri/freesurfer/bem.py
       8    ./nipype/utils/tests/test_docparse.py
       8    ./nipype/pipeline/plugins/multiproc.py
       8    ./nipype/pipeline/plugins/linear.py
       8    ./nipype/interfaces/afni/base.py
       7    ./setup_egg.py
       7    ./nipype/utils/tests/test_misc.py
       7    ./nipype/interfaces/slicer/legacy/converters.py
       7    ./doc/sphinxext/ipython_console_highlighting.py
       6    ./tools/nipype_nightly.py
       6    ./nipype/interfaces/spm/tests/test_base.py
       6    ./nipype/interfaces/nipy/preprocess.py
       6    ./nipype/algorithms/tests/test_rapidart.py
       5    ./tools/github.py
       4    ./tools/report_coverage.py
       4    ./tools/make_examples.py
       4    ./nipype/utils/matlabtools.py
       4    ./nipype/utils/config.py
       4    ./nipype/pipeline/plugins/tests/test_base.py
       4    ./nipype/pipeline/plugins/sge.py
       4    ./nipype/pipeline/plugins/pbs.py
       4    ./nipype/pipeline/plugins/lsf.py
       4    ./nipype/pipeline/plugins/debug.py
       4    ./nipype/interfaces/slicer/filtering/__init__.py
       4    ./examples/howto_caching_example.py
       3    ./tools/toollib.py
       3    ./tools/build_interface_docs.py
       3    ./nipype/pkg_info.py
       3    ./nipype/interfaces/tests/test_utility.py
       3    ./nipype/interfaces/tests/test_io.py
       3    ./nipype/interfaces/spm/__init__.py
       3    ./nipype/algorithms/tests/test_icc.py
       2    ./tools/setup.py
       2    ./tools/gitwash_dumper.py
       2    ./tools/apigen.py
       2    ./nipype/workflows/warp/setup.py
       2    ./nipype/workflows/smri/setup.py
       2    ./nipype/workflows/smri/ants/__init__.py
       2    ./nipype/workflows/setup.py
       2    ./nipype/workflows/rsfmri/setup.py
       2    ./nipype/workflows/rsfmri/fsl/setup.py
       2    ./nipype/workflows/misc/setup.py
       2    ./nipype/workflows/graph/setup.py
       2    ./nipype/workflows/fmri/spm/setup.py
       2    ./nipype/workflows/fmri/setup.py
       2    ./nipype/workflows/fmri/fsl/setup.py
       2    ./nipype/workflows/dmri/setup.py
       2    ./nipype/workflows/dmri/mrtrix/setup.py
       2    ./nipype/workflows/dmri/fsl/setup.py
       2    ./nipype/workflows/dmri/camino/setup.py
       2    ./nipype/utils/spm_docs.py
       2    ./nipype/utils/setup.py
       2    ./nipype/testing/setup.py
       2    ./nipype/testing/__init__.py
       2    ./nipype/setup.py
       2    ./nipype/pipeline/setup.py
       2    ./nipype/pipeline/plugins/sgegraph.py
       2    ./nipype/pipeline/plugins/setup.py
       2    ./nipype/pipeline/plugins/condor.py
       2    ./nipype/interfaces/spm/setup.py
       2    ./nipype/interfaces/spm/base.py
       2    ./nipype/interfaces/slicer/setup.py
       2    ./nipype/interfaces/slicer/legacy/setup.py
       2    ./nipype/interfaces/mrtrix/setup.py
       2    ./nipype/interfaces/mne/setup.py
       2    ./nipype/interfaces/fsl/setup.py
       2    ./nipype/interfaces/freesurfer/setup.py
       2    ./nipype/interfaces/dipy/setup.py
       2    ./nipype/interfaces/cmtk/setup.py
       2    ./nipype/interfaces/camino2trackvis/setup.py
       2    ./nipype/interfaces/camino/setup.py
       2    ./nipype/interfaces/ants/__init__.py
       2    ./nipype/interfaces/afni/setup.py
       2    ./nipype/fixes/setup.py
       2    ./nipype/external/setup.py
       2    ./nipype/algorithms/setup.py
       2    ./nipype/__init__.py
       2    ./examples/dmri_tbss_nki.py
       1    ./tools/build_modref_templates.py
       1    ./nipype/workflows/warp/__init__.py
       1    ./nipype/workflows/smri/freesurfer/__init__.py
       1    ./nipype/workflows/smri/__init__.py
       1    ./nipype/workflows/misc/__init__.py
       1    ./nipype/workflows/graph/__init__.py
       1    ./nipype/workflows/fmri/spm/__init__.py
       1    ./nipype/workflows/dmri/fsl/__init__.py
       1    ./nipype/workflows/dmri/camino/__init__.py
       1    ./nipype/workflows/dmri/__init__.py
       1    ./nipype/utils/tmpdirs.py
       1    ./nipype/utils/tests/__init__.py
       1    ./nipype/utils/__init__.py
       1    ./nipype/pipeline/plugins/somaflow.py
       1    ./nipype/interfaces/slicer/segmentation/__init__.py
       1    ./nipype/interfaces/slicer/registration/__init__.py
       1    ./nipype/interfaces/slicer/legacy/__init__.py
       1    ./nipype/interfaces/slicer/diffusion/__init__.py
       1    ./nipype/interfaces/slicer/base.py
       1    ./nipype/interfaces/slicer/__init__.py
       1    ./nipype/interfaces/mrtrix/__init__.py
       1    ./nipype/interfaces/fsl/__init__.py
       1    ./nipype/interfaces/freesurfer/base.py
       1    ./nipype/interfaces/freesurfer/__init__.py
       1    ./nipype/interfaces/diffusion_toolkit/base.py
       1    ./nipype/interfaces/__init__.py
       1    ./nipype/fixes/__init__.py
       1    ./nipype/caching/tests/test_memory.py
       1    ./nipype/caching/__init__.py
       1    ./nipype/algorithms/__init__.py
       0    ./nipype/workflows/smri/freesurfer/setup.py
       0    ./nipype/workflows/rsfmri/fsl/__init__.py
       0    ./nipype/workflows/rsfmri/__init__.py
       0    ./nipype/workflows/fmri/spm/tests/__init__.py
       0    ./nipype/workflows/fmri/spm/estimate.py
       0    ./nipype/workflows/fmri/fsl/__init__.py
       0    ./nipype/workflows/fmri/__init__.py
       0    ./nipype/workflows/dmri/mrtrix/__init__.py
       0    ./nipype/workflows/dmri/fsl/tests/__init__.py
       0    ./nipype/workflows/dmri/connectivity/__init__.py
       0    ./nipype/workflows/__init__.py
       0    ./nipype/testing/utils.py
       0    ./nipype/pipeline/tests/__init__.py
       0    ./nipype/pipeline/plugins/tests/test_callback.py
       0    ./nipype/pipeline/plugins/tests/__init__.py
       0    ./nipype/pipeline/plugins/pbsgraph.py
       0    ./nipype/pipeline/plugins/__init__.py
       0    ./nipype/pipeline/engine.py
       0    ./nipype/pipeline/__init__.py
       0    ./nipype/interfaces/tests/test_matlab.py
       0    ./nipype/interfaces/slicer/quantification/__init__.py
       0    ./nipype/interfaces/slicer/legacy/diffusion/__init__.py
       0    ./nipype/interfaces/setup.py
       0    ./nipype/interfaces/nitime/__init__.py
       0    ./nipype/interfaces/nipy/__init__.py
       0    ./nipype/interfaces/mne/__init__.py
       0    ./nipype/interfaces/fsl/base.py
       0    ./nipype/interfaces/dipy/tensors.py
       0    ./nipype/interfaces/dipy/__init__.py
       0    ./nipype/interfaces/diffusion_toolkit/__init__.py
       0    ./nipype/interfaces/cmtk/__init__.py
       0    ./nipype/interfaces/camino2trackvis/__init__.py
       0    ./nipype/interfaces/camino/__init__.py
       0    ./nipype/interfaces/ants/setup.py
       0    ./nipype/interfaces/afni/__init__.py
       0    ./nipype/fixes/numpy/testing/utils.py
       0    ./nipype/fixes/numpy/testing/__init__.py
       0    ./nipype/fixes/numpy/__init__.py
       0    ./nipype/external/__init__.py
       0    ./examples/smri_freesurfer.py
       0    ./doc/sphinxext/numpy_ext/__init__.py

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions