Skip to content

Updated auto test files to new PEP8 changes #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2015
Merged

Conversation

blakedewey
Copy link
Contributor

Ran make check-before-commit on current master. Should be merged quickly to avoid conflicts.

Ran make check-before-commit on current master
@satra
Copy link
Member

satra commented Nov 14, 2015

@blakedewey - did you update the generator? perhaps that would be the best way to ensure PEP8 compliance.

@blakedewey
Copy link
Contributor Author

The generator was updated with the PEP8 changes. But the tests were never remade for some reason.

@miykael
Copy link
Collaborator

miykael commented Nov 14, 2015

Yes, that was my mistake. I forgot to update the test files with my previous PR #1255, but corrected it with my second PEP8 PR #1264. Specifically with commit miykael@712ab69

@satra
Copy link
Member

satra commented Nov 15, 2015

since this is ready to merge, shall we merge this and cancel the other PR? or can the two of you consolidate to a single PR?

@blakedewey
Copy link
Contributor Author

Yes that would be great.

@miykael
Copy link
Collaborator

miykael commented Nov 16, 2015

I have no problem to cancel my commit with those changes. They are anyhow the same. But the commit is part of a PR (#1264) with 18 additional commits, all correcting additional PEP8 violations.
I can revert the changes of this commit and than update everything, once this PR is merged?

satra added a commit that referenced this pull request Nov 16, 2015
Updated auto test files to new PEP8 changes
@satra satra merged commit 5e381b4 into master Nov 16, 2015
@blakedewey blakedewey deleted the fix/pep8_auto_tests branch November 16, 2015 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants