Skip to content

FIX: Set networkx max version until 2.0 fixes are finalized #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

effigies
Copy link
Member

Fixes #2194.

Changes proposed in this pull request

  • Set networkx max version of 1.11

@effigies effigies mentioned this pull request Sep 23, 2017
@effigies
Copy link
Member Author

Looks like Travis just really hates afni.Hist all the sudden. So much for this working first.

@satra
Copy link
Member

satra commented Sep 23, 2017

i can't see anything in the code that would be weird. for the time being could you temporarily remove that particular test just to check travis?

also since circle runs on py36 with dependencies, it's weird that the error condition on travis is on the closest cell that circle runs on.

@effigies
Copy link
Member Author

@satra Note that all INSTALL_DEB_DEPENDENCIES=true lines are failing. Wonder if it's a neurodebian problem.

https://travis-ci.org/nipy/nipype/builds/278944845

@effigies
Copy link
Member Author

What test is actually failing? The doctest?

@codecov-io
Copy link

codecov-io commented Sep 23, 2017

Codecov Report

Merging #2195 into master will decrease coverage by 30.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2195       +/-   ##
===========================================
- Coverage   72.28%   42.16%   -30.13%     
===========================================
  Files        1171       68     -1103     
  Lines       58622    14497    -44125     
  Branches     8433        0     -8433     
===========================================
- Hits        42377     6113    -36264     
+ Misses      14887     8384     -6503     
+ Partials     1358        0     -1358
Flag Coverage Δ
#smoketests 42.16% <100%> (-30.13%) ⬇️
#unittests ?
Impacted Files Coverage Δ
nipype/info.py 84.61% <100%> (+0.24%) ⬆️
nipype/pipeline/plugins/callback_log.py 12% <0%> (-80%) ⬇️
nipype/interfaces/utility/wrappers.py 20.37% <0%> (-65.75%) ⬇️
nipype/pipeline/plugins/linear.py 22.85% <0%> (-65.72%) ⬇️
nipype/pipeline/plugins/pbsgraph.py 29.41% <0%> (-64.71%) ⬇️
nipype/pipeline/engine/nodes.py 23.3% <0%> (-61.59%) ⬇️
nipype/algorithms/modelgen.py 15.11% <0%> (-58.38%) ⬇️
nipype/interfaces/utility/csv.py 42.85% <0%> (-57.15%) ⬇️
nipype/interfaces/spm/base.py 29.18% <0%> (-55.52%) ⬇️
nipype/interfaces/utility/base.py 43.25% <0%> (-47.76%) ⬇️
... and 1132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0bd3d...3ee5f24. Read the comment docs.

@satra
Copy link
Member

satra commented Sep 23, 2017

re: doctest - i believe so.

neurodebian has not updated it since 2016, so i don't know what's going on there.

@effigies
Copy link
Member Author

Now it's skullstrip. Which I think are the two interfaces with redirect_x.

@satra
Copy link
Member

satra commented Sep 23, 2017

nothing is running though in those tests, just an initialization. i wonder whether the afni_vcheck command is failing. trying out now in a debian:stretch container.

@effigies
Copy link
Member Author

I think that's it. I can't hit https://afni.nimh.nih.gov/

@satra
Copy link
Member

satra commented Sep 23, 2017

just verified locally that it's afni_vcheck that's failing.

@effigies
Copy link
Member Author

effigies commented Sep 23, 2017 via email

@satra
Copy link
Member

satra commented Sep 23, 2017

timeout exists in subprocess for python 3, but python 2 needs some extra work.

@effigies
Copy link
Member Author

effigies commented Sep 23, 2017 via email

@satra
Copy link
Member

satra commented Sep 23, 2017

i think this should fix it: see: djarecka#3

@effigies
Copy link
Member Author

effigies commented Sep 23, 2017 via email

@effigies
Copy link
Member Author

Closing in favor of #2196.

@effigies effigies closed this Sep 23, 2017
@effigies effigies deleted the networkx_stopgap branch September 23, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants