-
Notifications
You must be signed in to change notification settings - Fork 532
FIX: Set networkx max version until 2.0 fixes are finalized #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like Travis just really hates afni.Hist all the sudden. So much for this working first. |
i can't see anything in the code that would be weird. for the time being could you temporarily remove that particular test just to check travis? also since circle runs on py36 with dependencies, it's weird that the error condition on travis is on the closest cell that circle runs on. |
@satra Note that all |
What test is actually failing? The doctest? |
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
===========================================
- Coverage 72.28% 42.16% -30.13%
===========================================
Files 1171 68 -1103
Lines 58622 14497 -44125
Branches 8433 0 -8433
===========================================
- Hits 42377 6113 -36264
+ Misses 14887 8384 -6503
+ Partials 1358 0 -1358
Continue to review full report at Codecov.
|
re: doctest - i believe so. neurodebian has not updated it since 2016, so i don't know what's going on there. |
Now it's skullstrip. Which I think are the two interfaces with redirect_x. |
nothing is running though in those tests, just an initialization. i wonder whether the afni_vcheck command is failing. trying out now in a debian:stretch container. |
I think that's it. I can't hit https://afni.nimh.nih.gov/ |
just verified locally that it's |
I think adding a <30s timeout would be a good idea. Nipype shouldn't depend
on the AFNI web server's availability.
…On Sep 23, 2017 1:04 PM, "Satrajit Ghosh" ***@***.***> wrote:
just verified locally that it's afni_vcheck that's failing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8s5PAL64e2ZoP1BStJoryT0T6OP2ks5slToEgaJpZM4PhjpD>
.
|
timeout exists in subprocess for python 3, but python 2 needs some extra work. |
Is there another way to get the version? I couldn't find a flag to avoid
fetching the url.
…On Sep 23, 2017 1:22 PM, "Satrajit Ghosh" ***@***.***> wrote:
timeout exists in subprocess for python 3, but python 2 needs some extra
work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8gpxMmyC2suzDfYVWbentPAuBxReks5slT5vgaJpZM4PhjpD>
.
|
i think this should fix it: see: djarecka#3 |
Looks reasonable, but I think Dorota is afk this weekend. Maybe just create
a PR from your branch?
…On Sep 23, 2017 2:04 PM, "Satrajit Ghosh" ***@***.***> wrote:
i think this should fix it: see: djarecka#3
<djarecka#3>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2195 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFF8rjOk0SHjnf7CDUD5KBiDjWUo3rUks5slUgbgaJpZM4PhjpD>
.
|
Closing in favor of #2196. |
Fixes #2194.
Changes proposed in this pull request