-
Notifications
You must be signed in to change notification settings - Fork 532
[ENH] New ResourceMonitor (replaces resource profiler) #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
da6681f
[WIP,ENH] Revision to the resource profiler
oesteban 32c2f39
fix tests
oesteban 0e2c581
Python 2 compatibility
oesteban 5a8e7fe
add nipype_mprof
oesteban 7d953cc
implement monitor in a parallel process
oesteban 306c4ec
set profiling outputs to runtime object, read it from node execution
oesteban 8a903f0
revise profiler callback
oesteban 02fdbda
Merge remote-tracking branch 'upstream/master' into enh/ReviseResourc…
oesteban e3982d7
robuster constructor
oesteban 48f87af
remove unused import
oesteban 46dde32
various fixes
oesteban 9d70a2f
cleaning up code
oesteban 1fabd25
remove comment
oesteban ecedfcf
interface.base cleanup
oesteban 2d35959
update new config settings
oesteban 3f34711
make naming consistent across tests
oesteban 99ded42
implement raise_insufficient
oesteban b0d25bd
fix test
oesteban 2a37693
fix test (amend previous commit)
oesteban 10d0f39
address review comments
oesteban 62a6593
fix typo
oesteban d6401f3
fixes to the tear-up section of interfaces
oesteban ce3f08a
fix NoSuchProcess exception
oesteban ffb7509
making monitor robuster
oesteban 7b7846b
Merge remote-tracking branch 'upstream/master' into enh/ReviseResourc…
oesteban c9b474b
first functional prototype
oesteban 117924c
Merge remote-tracking branch 'upstream/master' into enh/ReviseResourc…
oesteban cf1f15b
add warning to old filemanip logger
oesteban 4b7ab93
do not search for filemanip_level in config
oesteban c7a1992
fix CommandLine interface doctest
oesteban 80eb342
fix tests
oesteban c166c1d
fix location of use_resources
oesteban 16c195a
fix attribute error when input spec is not standard
oesteban cda3a5e
re-include filemanip logger into config documentation
oesteban 166205a
minor additions to resource_monitor option
oesteban 6045c93
fix resource_monitor tests
oesteban 66a89c4
run build 2 (the shortest) with the resource monitor on
oesteban 04adabd
fix unbound variable
oesteban c83c407
collect resource_monitor info after run
oesteban f8a9fc7
reduce resource_monitor_frequency on tests (and we test it works)
oesteban 8af3775
store a new trace before exit
oesteban 0b00a20
run resource_monitor only for level2 of fmri_spm_nested, switch pytho…
oesteban 6402981
cleaning up MultiProc
oesteban b9537b5
do not access __array__() of matrices
oesteban 9a609b6
do not access __array__() of matrices (now base plugin)
oesteban c7fbb61
do not access __array__() of matrices (revise)
oesteban a40eb3b
restore those __array__()
oesteban 8e710fa
address @satra's comments
oesteban 1bccef7
refactoring multiproc to fix deadlock
oesteban 5d13229
do not import iflogger from base plugin
oesteban a503fc8
improve logging traces
oesteban cb6ef02
fix tests
oesteban 9c2a8da
add test
oesteban 2fcaa45
improve debugging traces
oesteban 983ac37
make open python 2 compatible
oesteban ac19d23
address @effigies' comments
oesteban 7fbd869
fix error accessing config.has_option
oesteban b338e4f
make write_workflow_resources python 2 compatible (take 2)
oesteban 17d205d
circle tests - write txt crashfiles
oesteban 6edd5b5
fix outdated call to get_mem_gb and get_n_procs
oesteban 430a3b4
fix tests
oesteban 8a5e7a3
add MultiProc scheduler option
oesteban 43f32d5
fix initialization of NipypeConfig
oesteban b7b860b
add more documentation to MultiProc
oesteban 0137243
remove some code duplication checking hash locally
oesteban 6e00306
fix linting
oesteban 43ff268
remove leftover line that @satra spotted
oesteban d09ca59
improve logging to understand https://github.com/nipy/nipype/pull/220…
oesteban 013be14
prevent writing to same monitor
oesteban 427e668
improve documentation of DistributedBasePlugin
oesteban 34f9824
fix mistaken property name
oesteban 4883211
mv final resource_monitor.json to logs/ folder
oesteban 831071b
fix: add new config options and defaults to default_cfg
satra 966b7f1
improving measurement of resources, use oneshot from psutils>=5.0
oesteban 403961f
fix unconsistency of runtime attributes
oesteban 4e85b75
Merge pull request #6 from satra/ref/resourcemon
oesteban e7bc888
enable all tests in test_resource_monitor
oesteban ef097a6
do not delete num_threads, check inputs also
oesteban 4fdce5c
several fixups
oesteban 31a4952
retrieve num_threads from Interface object
oesteban 5fb992e
fix unnecessary, preemptive float castings
oesteban 2e1b2ce
a more consistent resource_monitor checking
oesteban 345e978
do not hook _nthreads_update to inputs.num_threads changes for afni i…
oesteban 1d7afbc
quickly return to polling function when no resources are available
oesteban c42473a
remove logging from run_node which blocked mriqc, improve logging of …
oesteban 8a887d3
Merge remote-tracking branch 'upstream/master' into enh/ReviseResourc…
oesteban d2599e2
disable resource_monitor tests when running tests in Circle and Travis
oesteban 678bb1a
let the inner interface set _n_procs and _mem_gb
oesteban File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a default when
resource_monitor=='true'
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added default value to the documentation