Skip to content

Make "Closing display" message show up less, and in the debug stream #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

oesteban
Copy link
Contributor

No description provided.

@oesteban oesteban requested a review from effigies October 12, 2017 16:40
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Was meaning to say something, but was tired of all the tweaks going in and taking 6 hours to percolate up.

@codecov-io
Copy link

Codecov Report

Merging #2225 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2225      +/-   ##
==========================================
+ Coverage   72.31%   72.32%   +<.01%     
==========================================
  Files        1180     1180              
  Lines       58885    58885              
  Branches     8474     8474              
==========================================
+ Hits        42583    42587       +4     
+ Misses      14923    14919       -4     
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.32% <0%> (ø) ⬆️
#unittests 69.88% <0%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/utils/config.py 67.64% <0%> (ø) ⬆️
nipype/utils/profiler.py 41.35% <0%> (+1.23%) ⬆️
nipype/pipeline/plugins/multiproc.py 78.16% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4e640...4269085. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 12, 2017

Codecov Report

Merging #2225 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2225      +/-   ##
==========================================
+ Coverage   72.31%   72.32%   +<.01%     
==========================================
  Files        1180     1180              
  Lines       58885    58885              
  Branches     8474     8474              
==========================================
+ Hits        42583    42587       +4     
+ Misses      14923    14919       -4     
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.32% <0%> (ø) ⬆️
#unittests 69.88% <0%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/utils/config.py 67.64% <0%> (ø) ⬆️
nipype/utils/profiler.py 41.35% <0%> (+1.23%) ⬆️
nipype/pipeline/plugins/multiproc.py 78.16% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4e640...4269085. Read the comment docs.

@effigies effigies merged commit 32966e7 into nipy:master Oct 12, 2017
@oesteban oesteban deleted the fix/remove-close-display-message branch October 12, 2017 21:52
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
@satra satra modified the milestone: 0.14.0 Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants