Skip to content

rearranging nilearn test, so they are independent from each other #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

djarecka
Copy link
Collaborator

I had problem when testing traitlets that tests were not completely independent from each other, so decided to remove the class and rearrange, so they run now in different directories etc.

@codecov-io
Copy link

Codecov Report

Merging #2226 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   72.32%   72.31%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       58885    58884       -1     
  Branches     8474     8473       -1     
==========================================
- Hits        42587    42582       -5     
- Misses      14919    14923       +4     
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (-0.01%) ⬇️
#unittests 69.88% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/tests/test_nilearn.py 97.59% <100%> (-0.03%) ⬇️
nipype/pipeline/plugins/multiproc.py 76.76% <0%> (-1.41%) ⬇️
nipype/utils/profiler.py 40.12% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32966e7...4342afc. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #2226 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   72.32%   72.31%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       58885    58884       -1     
  Branches     8474     8473       -1     
==========================================
- Hits        42587    42582       -5     
- Misses      14919    14923       +4     
  Partials     1379     1379
Flag Coverage Δ
#smoketests 72.31% <100%> (-0.01%) ⬇️
#unittests 69.88% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/tests/test_nilearn.py 97.59% <100%> (-0.03%) ⬇️
nipype/pipeline/plugins/multiproc.py 76.76% <0%> (-1.41%) ⬇️
nipype/utils/profiler.py 40.12% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32966e7...4342afc. Read the comment docs.

@djarecka
Copy link
Collaborator Author

I can add it to my traitlets PR

@djarecka djarecka closed this Oct 13, 2017
@satra satra added this to the 0.14.0 milestone Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants