Skip to content

ENH: More flexible BIDSDataGrabber creation #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

  • Remove outfields parameter - redundant with output_query input
  • Allows inputs to be specified in kwargs
  • auto tests

@adelavega
Copy link
Contributor

Cool. Although I think I had the outfields parameter because that gets called on init whereas output_query input is not called until run time. I figured the former would allow checking a workflow has the correct inputs/ouputs, but maybe that's not necessary?

@adelavega
Copy link
Contributor

Any desire to take care #2207 while you're at it? Although I'm not sure it was confirmed whether or not Python 2 support will be entirely dropped out of pybids, so maybe just add a skiptest if pybids was not installed in editable mode?

@oesteban
Copy link
Contributor

@adelavega, Chris' solution is equivalent to having outfields. Inputs can be passed through __init__ so you could always have done:

bids = BIDSDataGrabber(output_query={ ... })

and that would have the same effect as:

bids = BIDSDataGrabber(outfields={ ... })
bids.inputs.output_query = { ... }

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #2228 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   72.31%   72.32%   +<.01%     
==========================================
  Files        1181     1181              
  Lines       58939    58893      -46     
  Branches     8488     8476      -12     
==========================================
- Hits        42622    42593      -29     
+ Misses      14934    14920      -14     
+ Partials     1383     1380       -3
Flag Coverage Δ
#smoketests 72.32% <71.42%> (ø) ⬆️
#unittests 69.88% <71.42%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/bids_utils.py 81.03% <57.14%> (-0.22%) ⬇️
...pype/interfaces/tests/test_auto_BIDSDataGrabber.py 78.57% <78.57%> (ø)
nipype/interfaces/ants/utils.py 85.71% <0%> (-1.42%) ⬇️
...pe/interfaces/ants/tests/test_auto_Registration.py 85.71% <0%> (ø) ⬆️
nipype/utils/config.py 67.64% <0%> (ø) ⬆️
...aces/ants/tests/test_auto_ComposeMultiTransform.py
nipype/interfaces/ants/registration.py 75% <0%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af4d56...425a570. Read the comment docs.

@satra satra merged commit 0803819 into nipy:master Oct 16, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
@satra satra modified the milestone: 0.14.0 Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants