Skip to content

[ENH] Close file descriptors #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2017
Merged

[ENH] Close file descriptors #2260

merged 1 commit into from
Oct 29, 2017

Conversation

oesteban
Copy link
Contributor

When running large nipype graphs, the open file-descriptors end up provoking OSError 12 (could not allocate memory).

When running large nipype graphs, the open file-descriptors end up provoking OSError 12 (could not allocate memory).
@satra
Copy link
Member

satra commented Oct 28, 2017

LGTM - feel free to merge when tests pass.

@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #2260 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2260      +/-   ##
==========================================
- Coverage   72.33%   72.32%   -0.01%     
==========================================
  Files        1185     1182       -3     
  Lines       59039    58953      -86     
  Branches     8492     8486       -6     
==========================================
- Hits        42703    42640      -63     
+ Misses      14951    14929      -22     
+ Partials     1385     1384       -1
Flag Coverage Δ
#smoketests 72.32% <100%> (-0.01%) ⬇️
#unittests 69.9% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base.py 85.28% <100%> (+0.02%) ⬆️
nipype/interfaces/ants/resampling.py 78.48% <0%> (-1.98%) ⬇️
nipype/utils/profiler.py 41.35% <0%> (-0.21%) ⬇️
nipype/pipeline/engine/workflows.py 78.78% <0%> (-0.04%) ⬇️
nipype/pipeline/engine/utils.py 79.42% <0%> (-0.03%) ⬇️
nipype/interfaces/afni/tests/test_auto_Qwarp.py 85.71% <0%> (ø) ⬆️
nipype/utils/tests/test_misc.py 100% <0%> (ø) ⬆️
nipype/utils/functions.py
nipype/interfaces/cmtk/tests/test_nbs.py
nipype/utils/tests/test_functions.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40e056...bd7f00c. Read the comment docs.

@satra satra merged commit 557aad3 into nipy:master Oct 29, 2017
@oesteban oesteban deleted the fix/close_fds branch October 30, 2017 18:23
@oesteban
Copy link
Contributor Author

Just to mention that this did not fix the issue, I'm still getting memory errors in our settings. However, closing file descriptors is a good idea, so it is good that this is merged 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants