-
Notifications
You must be signed in to change notification settings - Fork 532
rel: some housekeeping for 1.0 #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good. We'll need a changelog update, but whether that's here or directly on master at release time is fine with me. |
nipype/info.py
Outdated
@@ -148,6 +148,7 @@ def get_nipype_gitversion(): | |||
'pydotplus', | |||
'pydot>=%s' % PYDOT_MIN_VERSION, | |||
'packaging', | |||
'yapf' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yapf
is not a runtime dependency. it has been added to a new label called specs below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah didn't see this earlier - sorry for the clutter
We may be good to go. Do we need to do any documentation updates before release? We'll need to establish processes for contributing to 1.x-maint vs 2.0-dev (or whatever we call the branches). |
@effigies - till we get the engine in place (which should be highest priority for @djarecka in the next few weeks), we can go with current contribution process and do updates on the 1.x branch (leave master as is). as soon as the engine is ready and tested, we can create the 2.0 branch and start moving things over to the new engine. |
i can do it |
use current master (10.12pm eastern or later) |
unfortunately my tests are failing on graphs, it's likely not related to nipype itself, but I'll debug it tomorrow: |
@satra @effigies were any changes to
|
#2381 was meant to remove the |
Good to merge and move tutorial discussion to #2397? |
Changes proposed in this pull request
make specs