Skip to content

CI/DOCKER: Hard code miniconda 4.3.31 #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2018
Merged

Conversation

effigies
Copy link
Member

Travis builds on master are failing, apparently because of today's miniconda release, which bundled asn1crypto 0.24. Possibly rolling back to 0.23 will fix the issue.

@satra
Copy link
Member

satra commented Feb 20, 2018

@effigies - perhaps it would be good to use wheels for all the installers. i think they all exist now. also i'm not sure if the icu issue is an issue still. may be worthwhile to synchronize this with the docker builds.

i think some of this comes from the time it takes to update conda forge packages.

@effigies
Copy link
Member Author

I'm not really sure what would be involved in such a change. If it's non-trivial, perhaps we should discuss Thursday. The 0.23 install had the same issue, so I've tried reverting to the most recent release of Miniconda. Assuming that passes, is that an acceptable stop-gap until then?

@effigies
Copy link
Member Author

(It looks to be passing.)

@effigies
Copy link
Member Author

Actually, it looks like the new Miniconda is breaking the Circle builds, too. They're retrying building the Docker images. I'm going to hard code the old one there, too.

This might be worth escalating, but I'm not sure where the best place to make noise would be.

@effigies effigies changed the title FIX: asn1crypto 0.24 incompatible with Python <= 3.6 CI/DOCKER: Hard code miniconda 4.3.31 Feb 20, 2018
@effigies
Copy link
Member Author

Okay, going to merge this to get tests passing again. I'll open a PR that reverts the hard-coding, so we can see if miniconda gets an update that fixes this, or move on to Satra's wheel installer approach.

@effigies effigies merged commit 04d0159 into nipy:master Feb 21, 2018
@effigies effigies deleted the fix/travis branch February 21, 2018 01:12
@effigies effigies added this to the 1.0.1 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants