Skip to content

FIX: mark .niml.dset as special extension in utils.filemanip #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

mvdoc
Copy link
Member

@mvdoc mvdoc commented Mar 11, 2018

All AFNI commands work also on files with extension .niml.dset (for surfaces).

Changes proposed in this pull request

  • consider *.niml.dset as special extension to correctly split filenames

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #2495 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2495   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files         328      328           
  Lines       42560    42560           
  Branches     5282     5282           
=======================================
  Hits        28457    28457           
  Misses      13405    13405           
  Partials      698      698
Flag Coverage Δ
#smoketests 50.79% <100%> (ø) ⬆️
#unittests 64.21% <100%> (-0.04%) ⬇️
Impacted Files Coverage Δ
nipype/utils/filemanip.py 76.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b440a...d35dde7. Read the comment docs.

@oesteban
Copy link
Contributor

LGTM

@satra satra merged commit f2aac9b into nipy:master Mar 14, 2018
@effigies effigies added this to the 1.0.2 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants