FIX: Prevent double-collapsing of nested lists by OutputMultiObject #2673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The saving/loading of results in
Node
causes anOutputMultiObject
that looks like[[x]]
to be collapsed twice intox
, as opposed to the expected[x]
.This PR detects collapses by performing a
clone_traits()
, which also collapses such traits, and wraps those values in a list.Fixes #2670.
List of changes proposed in this PR (pull-request)
_protect_collapses
helper function that mimicstrait_get
, but re-wraps collapsing traits in lists before returning the values.Acknowledgment